Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/releasing checklist #3781

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Aug 29, 2023

After #3775 is merged

@fendor fendor requested a review from michaelpj as a code owner August 29, 2023 11:30
@@ -19,6 +19,7 @@ Support status (see the support policy below for more details):
|--------------|--------------------------------------------------------------------------------------|-----------------------------------------------------------------------------|
| 9.6.2 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | basic support |
| 9.6.1 | [2.0.0.0](https://github.com/haskell/haskell-language-server/releases/tag/2.0.0.0) | basic support |
| 9.4.7 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.4.6 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.4.5 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the entries for 9.4.5 and 9.4.6 are wrong also? They should say the last supported version was something previous.

Copy link
Collaborator Author

@fendor fendor Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ship binaries for 9.4.6 and 9.4.5 with the 2.2.0.0 release as well, so the table is accurate afaict

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I missed that. I thought the policy was to only ship binaries for the last minor release of each major release?

Copy link
Collaborator Author

@fendor fendor Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, yeah, that's true, too.

I thought it would be better to ship binaries for these two older minor releases as well, so people don't have to upgrade immediately, don't invalidate their entire cabal store for a minor release, but still get an updated HLS version. There was no additional overhead to shipping the other binaries, iirc.

But I agree, that is against policy, but I slightly forgot about this part of the policy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, you know me, I just like there to be a policy so I know what we're doing :D

@michaelpj michaelpj enabled auto-merge (squash) August 29, 2023 15:57
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Aug 29, 2023
@michaelpj michaelpj disabled auto-merge September 1, 2023 10:42
@michaelpj michaelpj merged commit 9cdc7ed into haskell:master Sep 1, 2023
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants