Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main-is completion suggestions not being relative to hs-source-dirs #3766

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix main-is completion suggestions not being relative to hs-source-dirs #3766

merged 1 commit into from
Aug 21, 2023

Conversation

VeryMilkyJoe
Copy link
Collaborator

@VeryMilkyJoe VeryMilkyJoe commented Aug 18, 2023 •
edited
Loading

Fixes #3765.

Completion suggestions for the main-is field are now relative to the corresponding hs-source-dirs field.
Also added a test which ensures this.

@VeryMilkyJoe VeryMilkyJoe requested a review from fendor as a code owner August 18, 2023 11:15
@VeryMilkyJoe VeryMilkyJoe force-pushed the fp-completion-fix branch 3 times, most recently from 27ee748 to 379d385 Compare August 21, 2023 08:20
fendor
fendor requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise LGTM

plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Completer/Paths.hs Outdated Show resolved Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Completer/Paths.hs Outdated Show resolved Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs Outdated Show resolved Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs Outdated Show resolved Hide resolved
@VeryMilkyJoe VeryMilkyJoe force-pushed the fp-completion-fix branch 2 times, most recently from dd8aba8 to 3820877 Compare August 21, 2023 09:13
fendor
fendor approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fendor fendor added the merge me Label to trigger pull request merge label Aug 21, 2023
@mergify mergify bot merged commit 1ce58e7 into haskell:master Aug 21, 2023
@July541
Copy link
Collaborator

July541 commented Aug 21, 2023

@VeryMilkyJoe Is it possible to replace ./dir1/ with dir1 if no ambiguity here, I have some obsession about this...

@fendor
Copy link
Collaborator

fendor commented Aug 21, 2023

@July541 I think that's possible, can you create an issue?

@fendor fendor mentioned this pull request Aug 25, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make completion suggestions for main-is relative to hs-source-dirs
3 participants
@VeryMilkyJoe @July541 @fendor