Support resolve in type lenses #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Aug 5, 2023
|
Not sure why the CI isn't running. Maybe fix the conflicts and push again. |
michaelpj
approved these changes
Aug 8, 2023
| =~ ("(Top-level binding|Pattern synonym) with no type signature" :: T.Text) | ||
| , Just (GlobalBindingTypeSigsResult sigs) <- mGblSigs | ||
| , Just sig <- find (\x -> sameThing (gbSrcSpan x) _range) sigs | ||
| -- If a PositionMapping is supplied, this function will call |
There was a problem hiding this comment.
I think I made a comment about this and it got lost - why can't it be the caller's responsibility to map the Range?
There was a problem hiding this comment.
I marked your previous comment as resolved, because I did move the range position mapping stuff to the caller. However the position mapping is still sent to the function that generates lenses from the global signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to merge all signature related stuff into one plugin, as it gives refactoring flexibility in changing rules and some functions. Unfortunately, the plugin that currently includes those code actions is hls-refactor, which is very creatively engineered. Hence, I had to give up on that effort.
I have so far come across two bugs in type-lenses HEAD, one where long signatures are formatted incorrectly, which is fixed here by putting the signature into a single line. The other, where local bindings mostly don't work is still unresolved. I hope to solve that and fix it here before merging, but currently still unsure what's causing it.