Move Recorder to hls-plugin-api #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyfulmantis
requested review from
ozkutuk,
kokobd,
santiweight,
eddiemundo,
pepeiborra,
drsooch,
berberman and
fendor
as code owners
|
As I said on IRC, I think a bunch of the functions in |
michaelpj
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
I think we just need to think about what logging policy we want here. As I said in the comment, I think we shouldn't need to additionally log if we are throwing, since I would expect those all to be recorded generically. So then the question is when do we want to log? I think one answer is "if we make a decision that might not be obvious to the user", or if something interesting or unexpected happens and we're not throwing.
plugins/hls-explicit-imports-plugin/src/Ide/Plugin/ExplicitImports.hs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Recorder to hls-plugin-api, and implements logging in the Ide.Plugin.Resolve module.