Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 0: Generic support for resolve in hls packages #3678

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

joyfulmantis
Copy link
Collaborator

This is part of the larger resolve support pr group, and all of the other resolve pr's depend upon this one

@joyfulmantis joyfulmantis requested a review from berberman as a code owner June 27, 2023 14:14
@joyfulmantis joyfulmantis changed the title Generic support for resolve in hls packages Resolve 0: Generic support for resolve in hls packages Jun 27, 2023
@@ -983,3 +1012,107 @@ getProcessID = fromIntegral <$> P.getProcessID

installSigUsr1Handler h = void $ installHandler sigUSR1 (Catch h) Nothing
#endif

-- |When provided with both a codeAction provider and an affiliated codeAction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but this module is pretty big and could probably be split up.

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jun 29, 2023
@michaelpj michaelpj enabled auto-merge (squash) June 29, 2023 13:00
@michaelpj michaelpj merged commit 7860df3 into haskell:master Jun 29, 2023
@fendor fendor mentioned this pull request Aug 8, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants