hls-pragmas-plugin: Reduce noisy completions #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaymankar
requested review from
berberman,
Ailrun and
eddiemundo
as code owners
akshaymankar
force-pushed
the
avoid-unnecessary-pragmas
branch
from
8ae29e3 to
974d591
Compare
|
Could we get some comments? Sounds like it was somewhat non-obvious what to do? Not clear to me what the code does either... |
akshaymankar
force-pushed
the
avoid-unnecessary-pragmas
branch
from
427f7f7 to
8bae9e6
Compare
|
Thanks @michaelpj! I added comments, which helped me simplify things :) |
akshaymankar
force-pushed
the
avoid-unnecessary-pragmas
branch
from
8bae9e6 to
90f38f0
Compare
fendor
approved these changes
Jun 12, 2023
|
Has a conflict now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3617