Keep stale lenses for module name #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Apr 22, 2023
| L (locA -> (RealSrcSpan l _)) m <- MaybeT . pure . hsmodName . unLoc $ pm_parsed_source pm | ||
| pure (realSrcSpanToRange l, T.pack $ moduleNameString m) | ||
| let range = realSrcSpanToRange l | ||
| let range' = fromMaybe range (toCurrentRange mp range) |
There was a problem hiding this comment.
This seems wrong, shouldn't we fail or give up somehow if we can't map the range to the current thing, not use the probably-wrong range we have?
There was a problem hiding this comment.
Turns out I can't have a counterexample that toCurrentRange can fail, keep it unless we know how it fails.
There was a problem hiding this comment.
Seems risky to me 🤷 Why does it return a Maybe if it can't happen? And if it does happen we'll just silently do the wrong thing.
There was a problem hiding this comment.
Well, it makes sense, I'll let them be failed if toCurrentRange returns Nothing. But I'm still curious about how it fails 😅
There was a problem hiding this comment.
If you find out, please add some Haddock! 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1769