-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImportLens plugin to work with GHC 8.10 #356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ailrun
force-pushed
the
fix-import-code-lens
branch
from
August 27, 2020 16:24
178ebfc
to
a7fdeee
Compare
This comment has been minimized.
This comment has been minimized.
@mouse07410 Now it's fixed. |
Sorry, it still fails to compile:
|
It looks like this PR is missing this: diff --git a/src/Ide/Plugin/ImportLens.hs b/src/Ide/Plugin/ImportLens.hs
index 48110bc..86d38fe 100644
--- a/src/Ide/Plugin/ImportLens.hs
+++ b/src/Ide/Plugin/ImportLens.hs
@@ -31,6 +31,7 @@ import Development.IDE.Core.Shake (use, IdeState (..))
import Development.IDE.GHC.Compat
import Development.IDE.GHC.Error (realSpan, realSrcSpanToRange)
import Development.IDE.GHC.Util (HscEnvEq, hscEnv, prettyPrint)
+import GHC
import GHC.Generics (Generic)
import Ide.Plugin
import Ide.Types That patch seems to fix it. |
@mouse07410 Thanks, I will fix that and merge after CI succeed. |
Ailrun
force-pushed
the
fix-import-code-lens
branch
from
August 27, 2020 18:30
a7fdeee
to
32450e3
Compare
Sorry for all the pain, I merged a previous PR that broke this |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Sep 6, 2020
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355.