-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make nix ghc927 buildable #3555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibou
reviewed
Apr 7, 2023
guibou
approved these changes
Apr 7, 2023
CI is green. Let's merge this. I have a forgotten MR which simplify the |
cgeorgii
added a commit
to cgeorgii/haskell-language-server
that referenced
this pull request
Jun 10, 2023
PR haskell#3555 removes `cabal-install` in order to "make CI green" but that makes the project unbuildable using nix. Since the PR mentions not being sure of the details and more people at ZuriHac are having trouble with this, I'm suggesting reintroducing it.
cgeorgii
added a commit
to cgeorgii/haskell-language-server
that referenced
this pull request
Jun 10, 2023
PR haskell#3555 removes `cabal-install` in order to "make CI green" but that makes the project unbuildable using nix. Since the PR mentions not being sure of the details and more people at ZuriHac are having trouble with this, I'm suggesting reintroducing it.
michaelpj
pushed a commit
that referenced
this pull request
Jun 10, 2023
PR #3555 removes `cabal-install` in order to "make CI green" but that makes the project unbuildable using nix. Since the PR mentions not being sure of the details and more people at ZuriHac are having trouble with this, I'm suggesting reintroducing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the details, I am just making CI green.
Feel free to make changes.