-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inline code action to Retrie plugin #3444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
requested review from
isovector,
santiweight,
OliverMadine and
July541
as code owners
January 7, 2023 19:13
pepeiborra
force-pushed
the
retrie-inline
branch
from
January 7, 2023 19:23
69c8ac3
to
b8ea91f
Compare
This is ready for review: a look of @fendor at the test suite changes should be all is needed |
fendor
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the test-suite look good to me!
wz1000
pushed a commit
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new code action to hls-retrie-plugin that allows to inline a definition "on the spot". There are some caveats:
Another addition is a test suite for the plugin. Since hls-retrie-plugin depends on hls-refactor-plugin, the test suite needs to tell
goldenWithHaskellDoc
to run both plugins. I had to refactor a few things in order to make this possible, hence the large changeset.Screen.Recording.2023-01-07.at.20.08.49.mov