Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inline code action to Retrie plugin #3444

Merged
merged 11 commits into from
Jan 29, 2023
Merged

Add Inline code action to Retrie plugin #3444

merged 11 commits into from
Jan 29, 2023

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Jan 7, 2023

This adds a new code action to hls-retrie-plugin that allows to inline a definition "on the spot". There are some caveats:

  1. The code action only appears on identifiers for which we can locate the source code
  2. Inlining only works up to retrie capabilities. Currently retrie cannot inline functions that use pattern matching, for instance, and there are other bugs.

Another addition is a test suite for the plugin. Since hls-retrie-plugin depends on hls-refactor-plugin, the test suite needs to tell goldenWithHaskellDoc to run both plugins. I had to refactor a few things in order to make this possible, hence the large changeset.

Screen.Recording.2023-01-07.at.20.08.49.mov

@pepeiborra
Copy link
Collaborator Author

This is ready for review: a look of @fendor at the test suite changes should be all is needed

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the test-suite look good to me!

@pepeiborra pepeiborra merged commit 2b691b6 into master Jan 29, 2023
wz1000 pushed a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants