Add support for .env shells to flake.nix
#3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivation for this change is to enable development of HLS plugins by generating a `.env` shell for every package in this repository. Example usage: ```ShellSession $ nix develop .#haskell-language-server-dev-env.hls-fourmolu-plugin ``` This is a plain shell, though, without any tooling installed, identical to the one that Nixpkgs provides by default.
Gabriella439
requested review from
berberman,
michaelpj and
guibou
as code owners
|
@Gabriella439 Thank you for this contribution. Is it possible to add a bit of documentation (In the different Readme or directly in the flake file) so users will easily understand the difference between the different shells? This being said, I approved, so just add documentation if you have time and feel it, that's not a requirement. |
|
@Gabriella439 are you interested in helping to maintain the nix setup in this repo? You would be welcome to :) If so you could add yourself to CODEOWNERS. |
|
Yes, I am interested in helping maintain the Nix setup! I'll add myself as a CODEOWNER in a separate PR, though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this change is to enable development of HLS plugins by generating a
.envshell for every package in this repository.Example usage:
$ nix develop .#haskell-language-server-dev-env.hls-fourmolu-pluginThis is a plain shell, though, without any tooling installed, identical to the one that Nixpkgs provides by default.