Improved message for missing command or plugin #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft because of failing tests |
|
Does somebody know why this change - a different plugin error message - could result in this error?
https://github.com/haskell/haskell-language-server/actions/runs/3230899369/jobs/5289855473 I assumed the change could break existing golden tests, but the failing tests ( |
|
probably just a flaky test |
* No "PluginId" / "CommandId" prefix or quotes from show * No line break, but comma separated
andys8
force-pushed
the
error-message-no-plugin
branch
from
ea10ba8 to
4093226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening #3283 I noticed the error message if a plugin is missing can be improved.
Changes
showBefore
After