Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git): Add install/hie.yaml to gitignore #328

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

sir4ur0n
Copy link
Collaborator

Closes #326

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@sir4ur0n
Copy link
Collaborator Author

I think build failed for an unrelated reason, if anyone can restart it?

@jneira
Copy link
Member

jneira commented Aug 16, 2020

Maybe we could ignore all possible hie.yaml's in the code base with:

**/hie.yaml

?

@sir4ur0n I've reran the build!

@sir4ur0n
Copy link
Collaborator Author

Maybe we could ignore all possible hie.yaml's in the code base with:

**/hie.yaml

?

I thought about it but then thought "What if in the future some (integration?) tests want to test hie.yaml integration?".

If you prefer though, I can switch to wildcard hie.yaml rather than absolute paths, let me know!

@jneira
Copy link
Member

jneira commented Aug 16, 2020

I thought about it but then thought "What if in the future some (integration?) tests want to test hie.yaml integration?".

good point, better being cautious

@jneira jneira merged commit ce9219d into haskell:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add install/hie.yaml to .gitignore
3 participants