Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the stack requirement in wrapper tests #3212

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

ozkutuk
Copy link
Collaborator

@ozkutuk ozkutuk commented Sep 22, 2022

Some wrapper tests fail in the absence of stack on the system. This PR adds a small note in the testing section of the contributing page regarding that.

@ozkutuk ozkutuk changed the title Add a note regarding the stack requirement in wrapper tests Document the stack requirement in wrapper tests Sep 22, 2022
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fendor fendor added the merge me Label to trigger pull request merge label Sep 22, 2022
Copy link
Collaborator

@kokobd kokobd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you an approval

@mergify mergify bot merged commit b289e48 into haskell:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants