Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single file rewrites and ignore unknown files #321

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

pepeiborra
Copy link
Collaborator

Retrie is very slow and memory hungry on modules with lots of CPP.
For instance, it runs out of memory on Development.IDE.GHC.Compat.
This creates problems when rewriting (particularly folding). As a low key
workaround, this adds new code actions that rewrite only in the current file.

Rewriting on files without a cradle is also very slowbecause it results
in calls to hie-bios that fail after consulting with Cabal. Thus exclude them.

Retrie is very slow and memory hungry on modules with lots of CPP.
For instance, it runs out of memory on Development.IDE.GHC.Compat.
This creates problems when rewriting (particularly folding). As a low key
workaround, this adds new code actions that rewrite only in the current file.

Rewriting on files without a cradle is also very slowbecause it results
in calls to hie-bios that fail after consulting with Cabal. Thus exclude them.
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

I think it is time to seriously consider an alternative to CPP. That is tooling friendly and does 95% of what CPP in haskell is currently used for.

@pepeiborra pepeiborra merged commit c1c3680 into haskell:master Aug 27, 2020
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Sep 6, 2020
* Add single file rewrites and ignore unknown files

Retrie is very slow and memory hungry on modules with lots of CPP.
For instance, it runs out of memory on Development.IDE.GHC.Compat.
This creates problems when rewriting (particularly folding). As a low key
workaround, this adds new code actions that rewrite only in the current file.

Rewriting on files without a cradle is also very slowbecause it results
in calls to hie-bios that fail after consulting with Cabal. Thus exclude them.

* rearrange imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants