-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy on plugin support tiers #3189
Conversation
f33702e
to
a00d151
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very detailed description!
So, we can announce "fully" support of ghc-9.2 and drop the support of 8.6.5 and 8.8.4? |
I'm not sure. We have said that we won't do this until there is a 9.2 LTS stackage. I don't know if that's something we want to stick to, given that we're not using stack really for building or distribution any more. But we can discuss that separately, maybe at the HLS meeting? |
In case I don't make it to the HLS meeting, I am going to voice my concerns here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how this is a good thing, but unless we automatically generate the plugins table, I can also see user issues in the future when the plugins table becomes outdated
docs/support/plugin-support.md
Outdated
| `hls-brittany-plugin` | 3 | 9.2, 9.4 | | ||
| `hls-haddock-comments-plugin` | 3 | 9.2, 9.4 | | ||
| `hls-stan-plugin` | 3 | 8.6, 9.0, 9.2, 9.4 | | ||
| `hls-retrie-plugin` | 3 | 9.2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `hls-retrie-plugin` | 3 | 9.2 | | |
| `hls-retrie-plugin` | 3 | 9.2, 9.4 | |
## Current plugin support tiers | ||
|
||
| Plugin | Tier | Unsupported GHC versions | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table needs to be autogenerated, right? It should be not hard using the cabal-syntax
package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not currently, and we do have trouble keeping it up-to-date. But it's still useful information, and I volunteer to maintain it until/unless we get to a point that we can auto-generate it.
The tier information also is manual and I don't think could be emitted from the plugin. Conceivably we could record all this information in the plugins and then have a haskell-language-server describe-plugins
command that dumped it out, and then do that for all versions...
Following discussion in #3123. This aims to make it more obvious what it means when we say we support a version of GHC.
9475ce6
to
a51cc44
Compare
Let's give this a try at least. |
Following discussion in
#3123.
This aims to make it more obvious what it means when we say we support a version of GHC.