Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: more advanced Vim / Coc example (suggestion) #3181

Merged

Conversation

andys8
Copy link
Collaborator

@andys8 andys8 commented Sep 16, 2022

I wasn't aware how to properly configure CoC language servers so that they're recognized by haskell language server (see #3157 (comment)). Might be possible that the configuration changed. Therefore I'd suggest to add an example showing how to configure settings for plugins. I chose to add a second example in order to keep the default example minimal and avoid confusing people who want an easy way to start with.

This suggestion is open for discussion. I can see how this could somehow be redundant, or more than necessary for a minimal example. At the same time when I did want to look up how the configuration should be defined, I didn't find any information.

By the way, I also updated the example in the CoC wiki

docs/configuration.md Outdated Show resolved Hide resolved
@michaelpj
Copy link
Collaborator

I think this is good! That section is light because a) we need someone who actually knows CoC to fill it in (which it seems like you do, which is great) and b) we want to avoid duplicating information from the client documentation. But I think having a slightly bigger example here is great!

Adding an example with settings
@andys8 andys8 force-pushed the improvement/docs-more-advanced-vim-coc-example branch from ed93c2d to 25b410a Compare September 17, 2022 10:58
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Sep 17, 2022
@mergify mergify bot merged commit aee7372 into haskell:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants