-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hls-retrie-plugin to be usable with 9.2.4. #3120
Conversation
@pepeiborra - Here's a first pass. Functionality seems to be the same. I don't see any major differences that would break anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for helping with this!
This is the first pass at getting hls-retrie-plugin enabled. Much of the changes were updating to match the changes in the upstream `retrie` package.
Is the intended operation for Here's a sample output for running The I compared with current master branch, and it appears this continuous parsing is a by-product of the file itself. So it doesn't look like this is a new issues. |
Yes, this is how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hls-code-range-plugin
looks good to me.
Looks like there's some files that snuck through to master without formatting. Those are cleaned up here. |
This reverts commit 4f6eee5.
* Update hls-retrie-plugin to be usable with 9.2.4. This is the first pass at getting hls-retrie-plugin enabled. Much of the changes were updating to match the changes in the upstream `retrie` package. * Replace GHC.Paths.libdir by querying a ModSummary for the LibDir * Looks like formatting was missed * Revert "Looks like formatting was missed" This reverts commit 4f6eee5. * Don't build retrie for 9.4 Co-authored-by: Pepe Iborra <[email protected]>
This is the first pass at getting hls-retrie-plugin enabled. Much of the
changes were updating to match the changes in the upstream
retrie
package.