Remove pluginId from getNormalizedFilePath error message #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message displayed by `prettyResponseError` in `Development.IDE.Plugin.HLS` looks awkward with the pluginId. This error is not the fault of plugins anyways, so let's just be generic.
drsooch
requested review from
July541,
Ailrun,
jneira,
berberman and
pepeiborra
as code owners
pepeiborra
approved these changes
Aug 20, 2022
michaelpj
approved these changes
Aug 21, 2022
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
Sep 12, 2022
The error message displayed by `prettyResponseError` in `Development.IDE.Plugin.HLS` looks awkward with the pluginId. This error is not the fault of plugins anyways, so let's just be generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message displayed by
prettyResponseErrorinDevelopment.IDE.Plugin.HLSlooks awkward with the pluginId. This erroris not the fault of plugins anyways, so let's just be generic (we also should never see this message anyway).
New message: