Deduplicate HLS plugins #3112
Deduplicate HLS plugins #3112
Conversation
|
I think it would be better to use a Map, and then use an explicit priority (a simple Perhaps we also want a richer graph structure in the future so we can express dependencies between plugins, but lets just go for explicit priorities for now. |
pepeiborra
force-pushed
the
deduplicate-plugins
branch
from
41446c8 to
2a7561b
Compare
Agreed, explicit priorities are much better. Added now |
pepeiborra
force-pushed
the
deduplicate-plugins
branch
3 times, most recently
from
76a6cff to
7baaaab
Compare
Use a smart constructor to prevent duplicated plugins. We cannot use a set since order matters
pepeiborra
force-pushed
the
deduplicate-plugins
branch
from
7baaaab to
ccefa4e
Compare
| @@ -113,6 +152,8 @@ instance Show (IdeCommand st) where show _ = "<ide command>" | |||
| data PluginDescriptor (ideState :: *) = | |||
| PluginDescriptor { pluginId :: !PluginId | |||
| -- ^ Unique identifier of the plugin. | |||
| , pluginPriority :: Natural | |||
There was a problem hiding this comment.
What happens if two plugins have the same priority?
There was a problem hiding this comment.
Unspecified order as decided by unordered-containers
|
|
||
| -- --------------------------------------------------------------------- | ||
|
|
||
| descriptor :: PluginId -> PluginDescriptor IdeState | ||
| descriptor plId = (defaultPluginDescriptor plId) | ||
| { pluginHandlers = mkPluginHandler J.STextDocumentCodeAction codeActionProvider | ||
| <> mkPluginHandler J.STextDocumentCompletion completion | ||
| , pluginPriority = ghcideCompletionsPluginPriority + 1 |
There was a problem hiding this comment.
Argh, I forgot adding a line there.
Use a smart constructor to prevent duplicated plugins. We cannot use a
set since order matters for plugin execution.