Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a prefix to plugin CPP definitions #3065

Merged
merged 2 commits into from
Jul 29, 2022
Merged

add a prefix to plugin CPP definitions #3065

merged 2 commits into from
Jul 29, 2022

Conversation

kokobd
Copy link
Collaborator

@kokobd kokobd commented Jul 29, 2022

fix #3064

@kokobd kokobd changed the title add a prefix to plugin CPP add a prefix to plugin CPP definitions Jul 29, 2022
@kokobd kokobd force-pushed the kokobd/cpp-prefix branch from f6b7e85 to 0ab5359 Compare July 29, 2022 07:08
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kokobd kokobd added the merge me Label to trigger pull request merge label Jul 29, 2022
@mergify mergify bot merged commit dc682ba into master Jul 29, 2022
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request Sep 12, 2022
@kokobd kokobd deleted the kokobd/cpp-prefix branch July 23, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not build with profiling due to CPP definition name clash with C standard library
2 participants