Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github precommit workflow #3060

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Add Github precommit workflow #3060

merged 4 commits into from
Jul 29, 2022

Conversation

lunaticare
Copy link
Contributor

@lunaticare lunaticare commented Jul 24, 2022 •
edited
Loading

Add Github workflow to check code formatting in pull requests.

@lunaticare lunaticare force-pushed the github_precommit_hook branch 3 times, most recently from 63e3f98 to 9562c67 Compare July 24, 2022 14:13
@lunaticare lunaticare marked this pull request as ready for review July 24, 2022 14:17
@lunaticare lunaticare force-pushed the github_precommit_hook branch from 9562c67 to a883a55 Compare July 28, 2022 18:51
@lunaticare
Copy link
Contributor Author

@Ailrun now that #3059 is merged, we should be able to enforce pre-commit hooks by default :)

@Ailrun
Copy link
Member

Ailrun commented Jul 28, 2022

Oh I see where that Brittany issue happened... It's because

haskell-language-server/.pre-commit-config.yaml

Line 27 in 347a718

"exclude": "test/testdata/.*CRLF*.hs$"
starts with . (which I believe shouldn't)

Ailrun
Ailrun reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there was a concurrent PR without formatting (for Stan integration). Could you format the code as well?

.github/workflows/pre-commit.yml Show resolved Hide resolved
@lunaticare lunaticare requested a review from uhbif19 as a code owner July 28, 2022 21:08
@lunaticare lunaticare force-pushed the github_precommit_hook branch from 4e29989 to b247942 Compare July 28, 2022 21:22
Ailrun
Ailrun approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@Ailrun Ailrun merged commit 488d287 into haskell:master Jul 29, 2022
@lunaticare lunaticare deleted the github_precommit_hook branch July 29, 2022 07:31
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request Sep 12, 2022
@lunaticare @sloorush
Add Github precommit workflow (haskell#3060)
3a3ecd1 
* Add Github precommit workflow

* Reformat remaining files

* Don't shorten project name

* Fix pre-commit file exclusion pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@jneira jneira Awaiting requested review from jneira

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@fendor fendor Awaiting requested review from fendor fendor is a code owner

@drsooch drsooch Awaiting requested review from drsooch

@berberman berberman Awaiting requested review from berberman

@uhbif19 uhbif19 Awaiting requested review from uhbif19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lunaticare @Ailrun