Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(nix): ghc922 -> ghc923 #3049

Merged
merged 5 commits into from
Jul 20, 2022
Merged

build(nix): ghc922 -> ghc923 #3049

merged 5 commits into from
Jul 20, 2022

Conversation

teto
Copy link
Contributor

@teto teto commented Jul 19, 2022 •
edited by gitpod-io bot
Loading

bumped nixpkgs and add support for ghc923 (replacing ghc922)

build(nix): ghc922 -> ghc923
c05760b 
bumped nixpkgs and add support for ghc923 (replacing ghc922)
@teto teto marked this pull request as draft July 19, 2022 11:39
@teto teto marked this pull request as ready for review July 19, 2022 11:42
@michaelpj
Copy link
Collaborator

Looks like pre-commit fails to build?

Matthieu Coudron added 2 commits July 19, 2022 14:56
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jul 20, 2022
@teto
Copy link
Contributor Author

teto commented Jul 20, 2022

this CI reminds me of the kraken. Is it possible to resume the "Nix / build (pull_request)" please ?

@michaelpj
Copy link
Collaborator

I think it's fine, it's just waiting for some long checks after the merge. Mergify should handle it.

@mergify mergify bot merged commit 100b53a into haskell:master Jul 20, 2022
@teto teto deleted the ghc923 branch July 20, 2022 22:09
@michaelpj
Copy link
Collaborator

Argh, sorry, this shouldn't have been merged, I missed that the Nix build still isn't required. Something still seems to be broken on macos...

@teto
Copy link
Contributor Author

teto commented Jul 25, 2022 •
edited
Loading

yeah I was a bit surprised you merged it ^^'' but in a way I was relieved because the CI is slow. I suppose they run on the free tier, any chance we could use the runners from the GHC repo ? The cabal builds could use some caching too, I dont know if the nix builds are cached or not ? (maybe via cachix)

Also just wanted to mention that 923 worked fine in my project with a slight issue (ghc-related) that some constraint are marked redundant when they are not.

@July541 July541 mentioned this pull request Jul 29, 2022
Closed
8 tasks
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request Sep 12, 2022
@teto @mergify
@michaelpj @sloorush
build(nix): ghc922 -> ghc923 (haskell#3049)
66c8cd7 
* build(nix): ghc922 -> ghc923

bumped nixpkgs and add support for ghc923 (replacing ghc922)

* fixes

* fixing for ghc90?

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Michael Peyton Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@jneira jneira Awaiting requested review from jneira

@berberman berberman Awaiting requested review from berberman berberman is a code owner

@guibou guibou Awaiting requested review from guibou guibou is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teto @michaelpj