unify pre-commit hook & update Gitpod config #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokobd
requested review from
berberman,
michaelpj,
guibou and
jneira
as code owners
|
Can't speak to the Nix changes, but thanks for making the effort to make the config work for all parties :) |
drsooch
approved these changes
Jun 27, 2022
|
Some showcase: Gitpod Nix Running pre-commit (it takes a few seconds for the first run) |
michaelpj
reviewed
Jun 28, 2022
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* update Gitpod config * update nix shellHook & docs * install pre-commit hook * add kokobd as code owner to .gitpod.* * add gen-hie to Gitpod * add tools for doc * remove .pre-commit-config.yaml from .gitignore * set vscode formatter to stylish-haskell in Gitpod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #2967.
Previously:
.pre-commit-config.yamlis tracked by Gitflake.nixcontains an outdated pre-commit configflake.nixrelies on the non-existence of.pre-commit-config.yamlto work, so its' broken now.pre-commit-config.yaml, which doesn't work nowpre-commitsupport in Gitpod.In this PR, I unify pre-commit config, preserving
.pre-commit-config.yaml.pre-commit-config.yamlfrom.gitignoreMeanwhile, I make some changes to the Gitpod config, making it easier to use (this PR is written on Gitpod):
/nixbetween workspace restarts. Cache~/.local,~/.cabal,~/.stackand~/.ghcupin the same way using mount binding. Tedious configuration of environment variables to pointcabal,stackandghcupto/workspaceis no longer needed.gitpod.Dockerfile. In this way, VSCode will be able to see them without any special configuration..gitpod.yml, as it is required according to our style guidelines.