-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nix): bump nixpkgs to prevent glibc issues #2937
Conversation
Approved. The problem with this is that it will break nix flake for all users who are using older nixpkgs version. A more robust solution would be to encourage users to use the nix flake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new .pre-commit-config.yaml
is a link into your nix store, which seems definitely wrong...
To give a bit more context about this issue. Nixpkgs bumped Nix flake provide reproducible build because HLS is set to use a specific nixpkgs. However a user of the HLS flack may use another version of nixpkgs, with incompatible glibc. In theory, it is not a problem. However, HLS (built with The |
I don't think the flake is really a reliable way of getting HLS installed on your system for this reason amongst others. Most users just install it from |
I had failed to see that the pre-commit hook was versioned. Seems like pre-commit is installed via
When it comes to software installation, I find nix is the most reliable. but true historically (with HIE too) there has been glibc issues with HLS, not sure why. I sometimes need to fetch a HLS from master because of some bugfixes and flakes make it incredibly easy to test/update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement regardless!
I've had errors with the current HLS built via nix since it uses an older
nixpkgs than mine with a different glibc
NB: Maybe I should add pre-commit to the devShell since I got: