Stan integration #258 #2908

uhbif19 · 2022-05-16T03:17:01Z

#258

plugins/hls-stan-plugin/test/testdata/test.hs

CODEOWNERS

plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs

michaelpj · 2022-05-16T09:33:57Z

plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs

+            ]
+              ++ map ("  - " <>) (inspectionSolution inspection)
+
+getHieFile :: NormalizedFilePath -> Action (Maybe HieFile)


This seems like something we should provide alongside the other HIE stuff? WDYT @wz1000 ?

At least this needs some comments.

@michaelpj For me this function signature looks pretty self-explanatory. What else could be said about it?

Here are a list of questions that I have about this function after reading it:

Why isn't this function provided with the other HIE file functions we have? Is it doing something suspicious? Is there a reason we don't want to provide HIE files? Is it working against the direction of travel with hiedb?

How does it work? Are we sure we're constructing HIE files correctly? Can the information we get from the rules be inconsistent with what's coming from hiedb?

I'm sure you thought about a bunch of these things when you were writing it, but all that knowledge is going to be lost unless it gets written down! :)

This function was written by @pepeiborra , so I do not know the answers #258 (comment)

I believe that we have code to create HieFile in Core.Rules and/or Core.Compile

It would be nice to merge it with getHieFile in order to ensure that it stays working.

You mean creating separate rule for HieFile?

No, just abstracting and reusing the same code everywhere

@pepeiborra I do not know which code should be abstracted.

Fair enough

uhbif19 · 2022-05-16T10:01:38Z

I do not understand why CI fails. Plugin is disabled for GHC < 9, but Cabal build still fails: https://github.com/haskell/haskell-language-server/pull/2908/files#diff-aaf5dad5ddf1d2c16a2e8034c6435719f6eb3327cfe1bcd042df5a84b939afe3R282

michaelpj · 2022-05-16T10:43:05Z

@pepeiborra changed how you have a plugin that's only enabled on some versions recently. I'm not sure what the right way is off the top of my head (@pepeiborra if you write something here I'll add it to the contributing docs).

pepeiborra · 2022-05-16T11:12:35Z

You need to set the buildable field of your library and possibly the test-suite too.Example

haskell-language-server/plugins/hls-haddock-comments-plugin/hls-haddock-comments-plugin.cabal

Lines 20 to 24 in 8cbefb7

    
           library 
        
             if impl(ghc >= 9.2) 
        
               buildable: False 
        
             else 
        
               buildable: True

plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs

haskell-language-server.cabal

July541 · 2022-05-20T05:32:46Z

Can we have a document as #2066 mentioned?

uhbif19 · 2022-05-20T10:47:08Z

Marked as draft, to squash comits before merging.

uhbif19 · 2022-05-21T12:14:53Z

I tried to use plugin, but it does not show anything to me.

Does something in VS Code Haskell need to be tweaked for this to work?
https://github.com/haskell/vscode-haskell/blob/e81160dbdb6be0ac8493f6dbc0983d27fa096ac7/package.json#L346

pepeiborra · 2022-05-22T11:53:31Z

Does something in VS Code Haskell need to be tweaked for this to work?

Not at all. I am in my phone right now, but if the test suite passes you should see the diagnostics in VSCode already.

michaelpj · 2022-05-22T17:22:34Z

I'm not sure that's true. I think all plugins automatically get a "globalOn" option that needs to be set to enable them. I'm not sure if there's a way to turn it on by default when testing (@berberman ?).

For vscode, we have an ongoing issue that nobody seems to be sure what the deal is with options in the vscode extension (see #2827). It would be great if someone could find out and help us document it.

July541 · 2022-05-22T17:46:19Z

if the test suite passes you should see the diagnostics in VSCode already.

Agree this.

Noticed you are using hint severity,it may not showy as you expected in vscode.

berberman · 2022-05-23T16:33:28Z

I'm not sure that's true. I think all plugins automatically get a "globalOn" option that needs to be set to enable them. I'm not sure if there's a way to turn it on by default when testing (@berberman ?).

If you don't specify globalOn in the lsp config for a plugin, which can be set by sendNotification SWorkspaceDidChangeConfiguration DidChangeConfigurationParams ... during the test, the default value True will be used:

haskell-language-server/hls-plugin-api/src/Ide/Plugin/Config.hs

Lines 116 to 118 in 310e6a4

    
           instance Default PluginConfig where 
        
             def = PluginConfig 
        
                 { plcGlobalOn         = True

So no worries about globalOn.

For vscode, we have an ongoing issue that nobody seems to be sure what the deal is with options in the vscode extension (see #2827). It would be great if someone could find out and help us document it.

Yes, I can write a documentation for that later.

pepeiborra · 2022-07-10T08:17:35Z

is this still in progress or ready for review?

uhbif19 · 2022-07-15T14:57:13Z

@pepeiborra Marked as ready to review.

pepeiborra · 2022-07-18T10:50:38Z

@uhbif19 there are stack build failures

pepeiborra

Looks good to me, but it would be nice to make the suggested refactoring

.github/workflows/test.yml

pepeiborra · 2022-07-18T10:55:18Z

plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs

+            ]
+              ++ map ("  - " <>) (inspectionSolution inspection)
+
+getHieFile :: NormalizedFilePath -> Action (Maybe HieFile)


Also, perhaps move this function to the ghcide package and refactor other pieces of similar code around the Core/Compile.hs and Core/Rules.hs modules.

Did you have a chance to look into this refactoring?

uhbif19 · 2022-07-27T18:59:28Z

@michaelpj CircleCI stuck again.

uhbif19 requested review from jneira and pepeiborra as code owners May 16, 2022 03:17

uhbif19 force-pushed the stan-support branch from 29d2368 to 90b8801 Compare May 16, 2022 03:22

Ailrun reviewed May 16, 2022

View reviewed changes

plugins/hls-stan-plugin/test/testdata/test.hs Show resolved Hide resolved

uhbif19 force-pushed the stan-support branch 2 times, most recently from 57fa2d1 to 45df923 Compare May 16, 2022 05:27

uhbif19 requested review from Anton-Latukha and michaelpj as code owners May 16, 2022 05:27

uhbif19 force-pushed the stan-support branch from 45df923 to 95c3b7f Compare May 16, 2022 05:28

uhbif19 changed the title ~~WIP: Stan integration #258~~ Stan integration #258 May 16, 2022

Initial Stan support

990f0bb

uhbif19 force-pushed the stan-support branch from 95c3b7f to 990f0bb Compare May 16, 2022 05:39

michaelpj reviewed May 16, 2022

View reviewed changes

Fixes

21c7a9a

uhbif19 force-pushed the stan-support branch 4 times, most recently from 3c812d7 to f8a592a Compare May 17, 2022 21:36

Ailrun reviewed May 17, 2022

View reviewed changes

plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs Show resolved Hide resolved

uhbif19 force-pushed the stan-support branch 2 times, most recently from 49cc3e2 to 3baa6e9 Compare May 18, 2022 15:42

Fix build

2d55f5c

uhbif19 force-pushed the stan-support branch from 3baa6e9 to 2d55f5c Compare May 18, 2022 18:39

Get rid of fromJust, more text, comments

1237ed3

uhbif19 requested a review from michaelpj May 19, 2022 19:19

July541 reviewed May 20, 2022

View reviewed changes

haskell-language-server.cabal Show resolved Hide resolved

uhbif19 added 2 commits May 20, 2022 13:43

Fixes

0ce3c7a

Add to Features fixed supported versions

b2f04a7

uhbif19 marked this pull request as draft May 20, 2022 10:46

This was referenced Jun 19, 2022

#2794 Initial HIndent support #2896

Closed

CircleCI CI tasks are stuck for my PR #2968

Closed

Merge branch 'master' into stan-support

ef33634

uhbif19 marked this pull request as ready for review July 15, 2022 14:56

uhbif19 and others added 2 commits July 15, 2022 18:00

Add stan to Stack extra-deps to fix build bug

2abaa35

Merge branch 'master' into stan-support

b4208b1

pepeiborra approved these changes Jul 18, 2022

View reviewed changes

uhbif19 and others added 4 commits July 20, 2022 21:45

Add stan deps to Stack extra-deps to fix build bug

29d773c

Move getHieFile

1ac2dab

Trigger CI

ed078d6

Merge branch 'master' into stan-support

234839b

pepeiborra enabled auto-merge (squash) July 22, 2022 22:44

uhbif19 requested a review from July541 July 23, 2022 21:11

Merge branch 'master' into stan-support

dd1fc5d

Merge branch 'master' into stan-support

325f9a5

pepeiborra merged commit 078fc14 into haskell:master Jul 27, 2022

sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request Sep 12, 2022

Stan integration haskell#258 (haskell#2908)

1442482

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stan integration #258 #2908

Stan integration #258 #2908

uhbif19 commented May 16, 2022 •

edited by gitpod-io bot

Loading

michaelpj May 16, 2022

michaelpj May 16, 2022

uhbif19 May 16, 2022

michaelpj May 16, 2022

uhbif19 May 16, 2022

pepeiborra Jul 20, 2022

uhbif19 Jul 20, 2022 •

edited

Loading

pepeiborra Jul 22, 2022

uhbif19 Jul 22, 2022

pepeiborra Jul 22, 2022

uhbif19 commented May 16, 2022

michaelpj commented May 16, 2022

pepeiborra commented May 16, 2022

July541 commented May 20, 2022

uhbif19 commented May 20, 2022 •

edited

Loading

uhbif19 commented May 21, 2022

pepeiborra commented May 22, 2022

michaelpj commented May 22, 2022

July541 commented May 22, 2022

berberman commented May 23, 2022

pepeiborra commented Jul 10, 2022

uhbif19 commented Jul 15, 2022

pepeiborra commented Jul 18, 2022

pepeiborra left a comment

pepeiborra Jul 18, 2022

uhbif19 commented Jul 27, 2022

Stan integration #258 #2908

Stan integration #258 #2908

Conversation

uhbif19 commented May 16, 2022 • edited by gitpod-io bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uhbif19 Jul 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uhbif19 commented May 16, 2022

michaelpj commented May 16, 2022

pepeiborra commented May 16, 2022

July541 commented May 20, 2022

uhbif19 commented May 20, 2022 • edited Loading

uhbif19 commented May 21, 2022

pepeiborra commented May 22, 2022

michaelpj commented May 22, 2022

July541 commented May 22, 2022

berberman commented May 23, 2022

pepeiborra commented Jul 10, 2022

uhbif19 commented Jul 15, 2022

pepeiborra commented Jul 18, 2022

pepeiborra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uhbif19 commented Jul 27, 2022

uhbif19 commented May 16, 2022 •

edited by gitpod-io bot

Loading

uhbif19 Jul 20, 2022 •

edited

Loading

uhbif19 commented May 20, 2022 •

edited

Loading