Make iface-error-test-1 less flaky #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
May 1, 2022
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
* remove duplicate log message * Fix expectNoMoreDiagnostics * redundant import * dead code * unnecessary do section * redundant log message * waitForProgressDone to improve consistency * redundant import
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* remove duplicate log message * Fix expectNoMoreDiagnostics * redundant import * dead code * unnecessary do section * redundant log message * waitForProgressDone to improve consistency * redundant import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2879 by ensuring that the barrage of graph builds triggered by the test are observed as deterministically as possible, which amounts to inserting calls to
waitForProgressDoneand usingopenDocinstead ofcreateDoc.While I was there, I also cleaned up a bunch of minor things in the ghcide codebase