Provide all format suggestions in AlternatFormat Code Action #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new function that converts a NextPragmaInfo (identifies the location to insert a new Pragma) into an Insertion that will insert the new Extension - Provide all format choices instead of only currently active extensions
pepeiborra
approved these changes
Mar 20, 2022
michaelpj
reviewed
Mar 20, 2022
| @@ -2,4 +2,4 @@ | |||
| module TIntDtoND where | |||
|
|
|||
| convertMe :: Integer | |||
| convertMe = 125.345e3 | |||
There was a problem hiding this comment.
Did you mean to change this?
There was a problem hiding this comment.
Yeah, I updated the way Integers are converted into NumDecimal Format
michaelpj
approved these changes
Mar 20, 2022
|
Genuine test failure? |
|
No, I forgot that files with no explicit |
|
Great, and thanks for updating the docs nicely! |
July541
pushed a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
…#2790) * Insert Language Extensions when required - Add new function that converts a NextPragmaInfo (identifies the location to insert a new Pragma) into an Insertion that will insert the new Extension - Provide all format choices instead of only currently active extensions * Update Test Suite * Update Documentation * Miscellaneous Cleanup * Push extraneous functions into where bindings * Remove unneeded logging * Add Haskell2010 pragma to fix 9.2 tests Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2772
Previously the alternate format plugin would only generate code actions based on enabled extensions. With this PR we now provide all formats as code actions and when necessary insert the required extension.
This PR also refactors a portion of the logic internal to the plugin so we can track the Extensions needed. Overall, functionality remains the same.