-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target GHC 9.2.2 #2787
Target GHC 9.2.2 #2787
Conversation
Development with 9.2.1 on M1 is entirely broken, it spent me a lot of time and finally found 9.2.2 is the solution. |
Looks like we need to deal with digital-asset/ghc-lib#352 |
For reference, here script works for my M1 chip machine
|
The branch protection rules need to be changed to require the 9.2.2 circleci job instead of the 9.2.1 one. |
environment: | ||
- STACK_FILE: "stack-9.2.1.yaml" | ||
# https://github.com/digital-asset/ghc-lib/issues/352 | ||
- CPATH: "/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ffi:$CPATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is broken with this: https://github.com/haskell/haskell-language-server/actions/runs/2012818868
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, apparently I did notice, but this wasn't fixed. It appears to be broken to this day. @pepeiborra do you remember what you did here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed this and #2936 is attempting to fix it up.
Base branch was modified
* Target GHC 9.2.2 * fix with-compiler * attempt to fix Mac build * attempt to fix stack * Apply @July541 suggestion * add missing space * fix yaml * another yaml fix
Apparently this PR broke the caching workflow and nobody noticed :/ |
Caching works now :) |
No description provided.