-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow import all constructors #2782
Conversation
With import A (A(B))
f = C it will cause |
This is a good idea, thanks for working on it! |
Did you consider checking if |
1c9c1b1
to
77def21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, thank you @July541 !
* Import all constructors * Rewrite the test * Exact print wildcard * Rerun circleci
This is for #2734
Brief intro:
With
it will suggest import
Foo(..)
now, likeimport A(Foo(..))
andAdd Foo(..) to the import list of A
.Note:
Support Now!
This doesn't work for record fields, ideally, we should support this.Example:
if we have
f = a
, we should also haveimport A(Foo(..))
. Maybe we can extendhaskell-language-server/ghcide/src/Development/IDE/Types/Exports.hs
Lines 64 to 70 in 621c2bb
with a field to indicate
a
's data type ifa
is a record field.