Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2693 #2780

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix #2693 #2780

merged 1 commit into from
Mar 14, 2022

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Mar 14, 2022

We need to update the package database state in the HscEnv after we update
its DynFlags. setSessionDynFlags handles this for us.

Comment on lines +780 to +781
evalGhcEnv hsc_env $ do
_ <- setSessionDynFlags $ df
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uff, I hate these side effects. Hope this function is going to be removed soon :D

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We need to update the package database state in the `HscEnv` after we update
its `DynFlags`. `setSessionDynFlags` handles this for us.
@wz1000 wz1000 force-pushed the wip/9.2-packages branch from e649f5b to ea6c792 Compare March 14, 2022 17:40
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Mar 14, 2022
@mergify mergify bot merged commit f146ef0 into master Mar 14, 2022
July541 pushed a commit to July541/haskell-language-server that referenced this pull request Mar 30, 2022
We need to update the package database state in the `HscEnv` after we update
its `DynFlags`. `setSessionDynFlags` handles this for us.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants