-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete HLS installer scripts #2773
Conversation
@@ -83,147 +93,6 @@ pkg install hs-haskell-language-server | |||
to install it. At the moment, HLS installed this way only supports the same GHC | |||
version as the ports one. | |||
|
|||
## Installation from source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could continue to describe installing from source with the same caveats as installing from Hackage, below. That is, it only builds a single binary for the current GHC. It would be a very short section, though: cabal install haskell-language-server
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it doesn't include the proper suffix, not sure if we want to do that. The wrapper might pick it by accident even if the version doesn't match. But no strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same is true of installing from Hackage, which we do document. That's why I'm suggesting we could document it with the same caveats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, will change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restored the docs with notice, but tried to minimise it in order to be not redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You deleted exe
, which is the main HLS executable 😅
Also there are a few references to the |
Ah, I thought I misclicked, but couldn't tell :D anyway, CI and you caught it ;D |
Cleaning up code is always good 😁 |
752db68
to
e194c06
Compare
Prefer ghcup for installations from source.
Co-authored-by: Julian Ospald <[email protected]>
e194c06
to
a0962d9
Compare
* Delete HLS installer scripts Prefer ghcup for installations from source. * Use simpler ghcup syntax Co-authored-by: Julian Ospald <[email protected]> Co-authored-by: Julian Ospald <[email protected]> Co-authored-by: Michael Peyton Jones <[email protected]>
Prefer ghcup for installations from source.
Since in the last release, the deprecation of this script has been announced, I figure it is time to pull the plug on it now, since ghcup covers all of its use-cases nicely.
One small regression: We no longer support stack for from source installations.
However, I bet it would be trivial to add something like that to ghcup if desired.