Implement cycle detection in hls-graph #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Time to go back to Shake? |
|
Since I am the sole maintainer of hls-graph, we need someone else to review my PRs. Are you happy to fill in that role @michaelpj @wz1000 ? |
pepeiborra
commented
Mar 7, 2022
| @@ -165,7 +170,7 @@ compute db@Database{..} key mode result = do | |||
| deps | not(null deps) | |||
| && runChanged /= ChangedNothing | |||
| -> do | |||
| void $ forkIO $ | |||
There was a problem hiding this comment.
Removed this forkIO because it made testing reverse deps impossible, and I can't justify the need for it anyway
|
I can give it a look, but if you'd like a substantive review I'll need to devote some time to understanding what is actually going on. |
|
Looks fairly straightforward. Allocations in the Cabal benchmark seem to be a bit higher, but I guess that is to be expected. |
wz1000
approved these changes
Mar 8, 2022
July541
pushed a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost completely lifted from Shake.
I also started a barebones test suite for hls-graph and removed some legacy option placeholders (
shakeThreadsandshakeFiles)