-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wz1000/hls-3 ghcide branch #275
Conversation
At b7de7ae89469693b76d92ca433119d91d3a9aac0
let options = (defaultIdeOptions sessionLoader) | ||
{ optReportProgress = clientSupportsProgress caps | ||
, optShakeProfiling = argsShakeProfiling | ||
, optTesting = IdeTesting argsTesting | ||
, optThreads = argsThreads | ||
-- , optCheckParents = checkParents config | ||
-- , optCheckProject = checkProject config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are commented out for now, should come from the hls config, but the default values are fine (check parents on save, always check project).
We can simplify the hls Main driver now:
Not necessarily in this PR though |
@pepeiborra The driver simplification is already in HLS, I think it came in with the PR for the binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!
At b7de7ae89469693b76d92ca433119d91d3a9aac0