Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for #2673 #2676

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Add a test for #2673 #2676

merged 3 commits into from
Feb 4, 2022

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Feb 1, 2022 •
edited by gitpod-io bot
Loading

I cannot reproduce #2673 locally. Let's see if CI can

jneira
jneira approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the tests is useful in its own and we can merge this

@jneira jneira added the merge me Label to trigger pull request merge label Feb 2, 2022
@mergify mergify bot merged commit 7695832 into master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @jneira