Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ghc-9.2] Fix refine-imports plugin #2601

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Conversation

mxxun
Copy link
Contributor

@mxxun mxxun commented Jan 17, 2022

newRdrName in Rename.hs seems to be a debugging leftover.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, ghc-9.2.1 will be pretty complete thanks to your work

@jneira jneira added the merge me Label to trigger pull request merge label Jan 17, 2022
@mxxun
Copy link
Contributor Author

mxxun commented Jan 17, 2022

I.....want to be clear that I'm doing plugins with comparatively trivial fixes first, and expect to run out of these soon :)

@jneira
Copy link
Member

jneira commented Jan 17, 2022

I.....want to be clear that I'm doing plugins with comparatively trivial fixes first, and expect to run out of these soon :)

Sure, it is relatively easy but it is required work nevertheless. hlint, brittany and maybe others needs changes in their underlying main library so i would skip them for now

@michaelpj
Copy link
Collaborator

Don't put yourself down, this is great work!

@mergify mergify bot merged commit 70bb0ab into haskell:master Jan 18, 2022
@mxxun mxxun deleted the fix-refine-imports branch January 21, 2022 19:22
@jneira jneira mentioned this pull request Jan 24, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants