Add support for ghc 9.0.2 #2567

jneira · 2022-01-05T15:15:43Z

It misses the nix config
We have to check the gitlab build
Closes Please, support GHC 9.0.2 #2541

.github/workflows/hackage.yml

.github/workflows/test.yml

michaelpj · 2022-01-05T17:02:29Z

.github/workflows/test.yml

@@ -144,7 +147,7 @@ jobs:

        run: cabal test wrapper-test --test-options="$TEST_OPTS --rerun-log-file .tasty-rerun-log-wrapper" || cabal test wrapper-test --test-options="$TEST_OPTS  --rerun-log-file .tasty-rerun-log-wrapper" || cabal test wrapper-test --test-options="$TEST_OPTS  --rerun-log-file .tasty-rerun-log-wrapper"

-      - if: matrix.test && matrix.ghc != '9.0.1'
+      - if: matrix.test && matrix.ghc != '9.0.1' && matrix.ghc != '9.0.2'


I wonder what would happen if we did this unconditionally but set the test suite to not be buildable on GHC 9 🤔 might error, might just succeed...

hmm i think it is good to build it even if the tests are gonna fail, or it will rot even with compile errors.
We are building all the test suites (with tests: true) and cabal doesnt have runnable: false 😉

Yeah, fair.

An alternative is mark them as ignored or broken for that hls version using tasty modifiers, but we are not using them that way for now

fendor · 2022-01-06T08:44:56Z

There is no release of hie-bios with support for GHC 9.0.2 yet. Going to make one now.

wz1000 · 2022-01-06T20:00:49Z

We don't need a whole new cabal.project for GHC 9.0.2. The one for 9.0.1 will suffice with a few small tweaks.

pepeiborra · 2022-01-06T20:01:13Z

Is there any way to avoid introducing a cabal-ghc902.project file? I see two reasonable options:

Keep it, and delete cabal-ghc901.project
Rename cabal-ghc901.project to cabal-ghc9.project and make it work for both

thomasjm · 2022-01-10T06:46:50Z

Thanks for putting this together! FWIW I tried to build it with stack build --stack-yaml stack-9.0.2.yaml and it doesn't build.

I had to add unix to extra-deps, and then it hit errors building ghc-parser-ex, hie-bios, ormolu, and fourmolu. Also a GHC panic building primitive-unlifted. Logs

jneira · 2022-01-10T06:55:11Z

Thanks for putting this together! FWIW I tried to build it with stack build --stack-yaml stack-9.0.2.yaml and it doesn't build.

I had to add unix to extra-deps, and then it hit errors building ghc-parser-ex, hie-bios, ormolu, and fourmolu. Also a GHC panic building primitive-unlifted. Logs

thank for trying, circleci is asking unix too, will try to fix it asap

jneira · 2022-01-10T07:23:16Z

Is there any way to avoid introducing a cabal-ghc902.project file? I see two reasonable options:
* Keep it, and delete `cabal-ghc901.project`

* Rename `cabal-ghc901.project` to `cabal-ghc9.project` and make it work for both

i am for renaming to cabal-ghc9.project, there is a small chance of make the 9.0.1 build fail or fail in hackage due to 9.0.2 specific tweaks but i suppose is small enough to worth the deduplication

jneira · 2022-01-10T07:27:16Z

after adding unix ci reached the error commented by @thomasjm for primitive-unlifted:

primitive-unlifted                > [ 7 of 18] Compiling Data.Primitive.Unlifted.MVar.Primops
primitive-unlifted                > ghc: panic! (the 'impossible' happened)
primitive-unlifted                >   (GHC version 9.0.2:
primitive-unlifted                > 	findSlot
primitive-unlifted                >   Can't find slot
primitive-unlifted                >   [PtrUnliftedSlot]
primitive-unlifted                >   [PtrLiftedSlot]
primitive-unlifted                >   Call stack:
primitive-unlifted                >       CallStack (from HasCallStack):
primitive-unlifted                >         callStackDoc, called at compiler/GHC/Utils/Outputable.hs:1230:37 in ghc:GHC.Utils.Outputable
primitive-unlifted                >         pprPanic, called at compiler/GHC/Types/RepType.hs:217:9 in ghc:GHC.Types.RepType
primitive-unlifted                > 
primitive-unlifted                > Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug

jneira · 2022-01-10T07:28:33Z

after adding unix ci reached the error commented by @thomasjm for primitive-unlifted:

issue in the ghc issue tracker: https://gitlab.haskell.org/ghc/ghc/-/issues/20908 😟

wz1000 · 2022-01-10T07:30:55Z

The solution is to use primitive-unlifted < 1.0

primitive-unflifted-1.0 does some shady things which aren't semantically valid.

jneira · 2022-01-10T07:37:50Z

The solution is to use primitive-unlifted < 1.0

thanks for the suggestion, it is not a direct dependency of hls so i guess it will be hard to make the hackage build works although we can force that version using cabal.project/stack.yaml

wz1000 · 2022-01-10T07:45:12Z

See nikita-volkov/primitive-extras#6

jneira · 2022-01-10T08:21:26Z

Ok we hit the hie-bios error with cabal:

 src/HIE/Bios/Ghc/Gap.hs:260:7: error:
Error:     • Couldn't match expected type ‘IncludeSpecs’
                  with actual type ‘[String] -> IncludeSpecs’
    • Probable cause: ‘IncludeSpecs’ is applied to too few arguments
      In the ‘includePaths’ field of a record
      In the expression:
        df
          {includePaths = IncludeSpecs
                            (map f $ G.includePathsQuote (includePaths df))
                            (map f $ G.includePathsGlobal (includePaths df))}
      In an equation for ‘mapOverIncludePaths’:
          mapOverIncludePaths f df
            = df
                {includePaths = IncludeSpecs
                                  (map f $ G.includePathsQuote (includePaths df))
                                  (map f $ G.includePathsGlobal (includePaths df))}
    |
260 |       G.IncludeSpecs
    |       ^^^^^^^^^^^^^^...

so we have to upgrade hie-bios

In stack we got another error, already pointed out by @thomasjm :

ghc-lib-parser-ex                 > /tmp/stack-bcedea5ffccdf320/ghc-lib-parser-ex-9.0.0.6/src/Language/Haskell/GhclibParserEx/GHC/Settings/Config.hs:18:1: error:
ghc-lib-parser-ex                 >     Could not load module ‘GHC.Platform’
ghc-lib-parser-ex                 >     It is a member of the hidden package ‘ghc-boot-9.0.2’.
ghc-lib-parser-ex                 >     Perhaps you need to add ‘ghc-boot’ to the build-depends in your .cabal file.
ghc-lib-parser-ex                 >     Use -v (or `:set -v` in ghci) to see a list of the files searched for.
ghc-lib-parser-ex                 >    |
ghc-lib-parser-ex                 > 18 | import GHC.Platform
ghc-lib-parser-ex                 >    | ^^^^^^^^^^^^^^^^^^^

We cant use 9.0.2 until all deps do not need allow-newer

And bump up index state to get lastest hie-bios

jneira · 2022-01-13T20:30:01Z

As expected the caching workflow was succesful: https://github.com/jneira/haskell-language-server/runs/4804786986?check_suite_focus=true

…e-server into ghc-9.0.2

jneira · 2022-01-16T18:48:47Z

@michaelpj @Anton-Latukha I ve changed the caching workflow to build bench deps adding some comments (and in other workflow filed) hope it makes thing a little bit clearer

Anton-Latukha

I was Ok with previous (pre 9.2.1 changes merge), & I am Ok with the recently mentioned caching changes.

jneira · 2022-01-16T19:24:03Z

The new caching workflow has been succesful here: https://github.com/jneira/haskell-language-server/actions/runs/1704688585

.github/workflows/build.yml

jneira added 3 commits January 5, 2022 16:20

Extract out ci build setup

ddfede4

Add required shell property

b956c3b

Add support for ghc-9.0.2

4caf4e1

jneira force-pushed the ghc-9.0.2 branch from 667ef4e to 4caf4e1 Compare January 5, 2022 15:26

Test ghc 9.0.2

bf280fa

michaelpj reviewed Jan 5, 2022

View reviewed changes

.github/workflows/hackage.yml Show resolved Hide resolved

michaelpj reviewed Jan 5, 2022

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

michaelpj reviewed Jan 5, 2022

View reviewed changes

wz1000 mentioned this pull request Jan 6, 2022

Build with GHC 9.2 #2503

Merged

Add unix boot package

77ffca7

jneira mentioned this pull request Jan 10, 2022

panic with ghc 9.0.2 haskell-primitive/primitive-unlifted#29

Open

jneira added 2 commits January 10, 2022 08:41

Use primitive-unlifted < 1.0

87a8c9d

Use primitive-unlifted < 1.0 for stack

81e8aab

jneira mentioned this pull request Jan 11, 2022

Make the primitive-unlifted bound more strict nikita-volkov/primitive-extras#6

Open

jneira added 2 commits January 11, 2022 08:20

Ude 9.0.1 for hackage

857edb9

We cant use 9.0.2 until all deps do not need allow-newer

Merge branch 'master' into ghc-9.0.2

23e6c82

jneira mentioned this pull request Jan 11, 2022

Support time 1.11 and Win32 2.12 jacobstanley/unix-compat#47

Merged

Use a unified cabal-ghc90.project

9421c63

And bump up index state to get lastest hie-bios

Anton-Latukha mentioned this pull request Jan 13, 2022

Please, fix CI caching #2584

Closed

jneira added 14 commits January 14, 2022 21:49

Merge remote-tracking branch 'upstream/master' into ghc-9.0.2

0c89870

Update snapshot to get new lsp

5dcec89

document flag

b44f58b

Document and build ghcide benchmark

bfedf97

Doc and use ghc-9.0.2 in hackage

4e535c7

Add ghc-9.2.1 to tested-with

2c7ac63

Use 9.0.2 in gitlab

d2f0216

Use last *molus

d210d99

Use same versions as cabal build

dd335b6

Merge branch 'master' into ghc-9.0.2

6326efe

Use cabal freeze versions

e27f56d

Merge branch 'ghc-9.0.2' of https://github.com/jneira/haskell-languag…

a5f5907

…e-server into ghc-9.0.2

Add dep for ghcide tests

e694ebb

one by one

47e213c

Merge branch 'master' into ghc-9.0.2

c1fc2ee

Anton-Latukha approved these changes Jan 16, 2022

View reviewed changes

jneira commented Jan 16, 2022

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

Unnecessary change

f965d3c

michaelpj approved these changes Jan 16, 2022

View reviewed changes

jneira added 3 commits January 16, 2022 22:13

Remove unnecessary flag

3e75867

Corrections

3a8e61e

Move blocks

3980b6d

jneira added the merge me Label to trigger pull request merge label Jan 16, 2022

Merge branch 'master' into ghc-9.0.2

6b8c707

mergify bot merged commit 3f46851 into haskell:master Jan 17, 2022

jneira mentioned this pull request Jan 24, 2022

Support for ghc-9.2.* #2179

Closed

32 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ghc 9.0.2 #2567

Add support for ghc 9.0.2 #2567

jneira commented Jan 5, 2022 •

edited by gitpod-io bot

Loading

michaelpj Jan 5, 2022

jneira Jan 5, 2022 •

edited

Loading

michaelpj Jan 6, 2022

jneira Jan 6, 2022

fendor commented Jan 6, 2022

wz1000 commented Jan 6, 2022

pepeiborra commented Jan 6, 2022

thomasjm commented Jan 10, 2022 •

edited

Loading

jneira commented Jan 10, 2022

jneira commented Jan 10, 2022 •

edited

Loading

jneira commented Jan 10, 2022

jneira commented Jan 10, 2022

wz1000 commented Jan 10, 2022

jneira commented Jan 10, 2022 •

edited

Loading

wz1000 commented Jan 10, 2022

jneira commented Jan 10, 2022

jneira commented Jan 13, 2022

jneira commented Jan 16, 2022

Anton-Latukha left a comment

jneira commented Jan 16, 2022

Add support for ghc 9.0.2 #2567

Add support for ghc 9.0.2 #2567

Conversation

jneira commented Jan 5, 2022 • edited by gitpod-io bot Loading

michaelpj Jan 5, 2022

Choose a reason for hiding this comment

jneira Jan 5, 2022 • edited Loading

Choose a reason for hiding this comment

michaelpj Jan 6, 2022

Choose a reason for hiding this comment

jneira Jan 6, 2022

Choose a reason for hiding this comment

fendor commented Jan 6, 2022

wz1000 commented Jan 6, 2022

pepeiborra commented Jan 6, 2022

thomasjm commented Jan 10, 2022 • edited Loading

jneira commented Jan 10, 2022

jneira commented Jan 10, 2022 • edited Loading

jneira commented Jan 10, 2022

jneira commented Jan 10, 2022

wz1000 commented Jan 10, 2022

jneira commented Jan 10, 2022 • edited Loading

wz1000 commented Jan 10, 2022

jneira commented Jan 10, 2022

jneira commented Jan 13, 2022

jneira commented Jan 16, 2022

Anton-Latukha left a comment

Choose a reason for hiding this comment

jneira commented Jan 16, 2022

jneira commented Jan 5, 2022 •

edited by gitpod-io bot

Loading

jneira Jan 5, 2022 •

edited

Loading

thomasjm commented Jan 10, 2022 •

edited

Loading

jneira commented Jan 10, 2022 •

edited

Loading

jneira commented Jan 10, 2022 •

edited

Loading