-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add hlint workflow #2537
CI: add hlint workflow #2537
Conversation
[skip circleci] |
It is a great moment to do a workflow change in HLint, because currently there are no hints, because all of them were cleared in #2523 which just merged. (& note that I reproduce the scope that old For example, after syncing GHC 9.2 PR to |
This is what `fmt.sh` runs.
7037565
to
7239dfb
Compare
hoverInfo ast = (Just range, prettyNames ++ pTypes) | ||
hoverInfo ast = (Just range, prettyNames ++ [] ++ pTypes) | ||
where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept this open to show that the workflow works.
6767680
to
7239dfb
Compare
I like this. Will wait for @jneira to share his thoughts and approve. Also need to add the new workflow to the GitHub PR requirements. |
Of course with availability to use different levels of messaging, the levels for hints can be tuned. |
84ab085
to
bf4e6fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, I like see this in another workflow, as it can be setup and run independently,
thanks!
hlint workflow added to required checks to merge |
We not see Workflow blocks on It is the same setup, but now information messages are not hidden inside build, but shown in review. Which motivates people to follow even soft linter suggestions. |
As I understand, CI installs executable & runs it.
HLint gives the same output regardless of the GHC versions, so there is no reason to run it inside GHC matrix. In fact HLint executable installed does not need GHC at all.