Test hls-pragmas-plugin in ci #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dont know why it is not here 🤦
|
This probably needs to be documented in the plugin cycle. (checked - it is there). |
Anton-Latukha
approved these changes
Dec 23, 2021
|
yeah, it seems it was not added in #1833 another thing to document in the contributing guide (with that comprehensive check list) 😅 |
|
Yes, it is there. But may be made more memorable. Also this probably can be automatically checked in the CI. For example - if there is a new folder in the Since in the otherwise case - CI actually does not check that the plugin works properly. |
|
Opened #2531 for this. |
|
[skip circleci] |
|
wow, tests passed, i was afraid they were bitrotten 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont know why it is not here 🤦