Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test hls-pragmas-plugin in ci #2530

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Test hls-pragmas-plugin in ci #2530

merged 2 commits into from
Dec 23, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Dec 23, 2021

Dont know why it is not here 🤦

Dont know why it is not here 🤦
@jneira jneira changed the title Test hls-pragmas-plugin Test hls-pragmas-plugin in ci Dec 23, 2021
@Anton-Latukha
Copy link
Collaborator

This probably needs to be documented in the plugin cycle.

(checked - it is there).

@Anton-Latukha Anton-Latukha added the merge me Label to trigger pull request merge label Dec 23, 2021
@jneira
Copy link
Member Author

jneira commented Dec 23, 2021

yeah, it seems it was not added in #1833

another thing to document in the contributing guide (with that comprehensive check list) 😅

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Dec 23, 2021

Yes, it is there. But may be made more memorable.

Also this probably can be automatically checked in the CI.

For example - if there is a new folder in the plugins - the test workflow is required to be changed (implying to add the entry).

Since in the otherwise case - CI actually does not check that the plugin works properly.

@Anton-Latukha
Copy link
Collaborator

Opened #2531 for this.

@Anton-Latukha
Copy link
Collaborator

[skip circleci]

@mergify mergify bot merged commit 9797e1b into master Dec 23, 2021
@jneira
Copy link
Member Author

jneira commented Dec 23, 2021

wow, tests passed, i was afraid they were bitrotten 😅

@Anton-Latukha Anton-Latukha deleted the jneira/test-pragmas-plugin branch December 23, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants