-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cabal-*.project: index-state +1s #2515
Conversation
This is vacuous change, Hackage rerolls to the previous snapshot time nevertheless of this change, but the caches get a new key namespace.
Ok. It currently fixes the cache situation for the time being. In https://github.com/haskell/haskell-language-server/runs/4584037502?check_suite_focus=true we see that for Windows build the input (partial) cache was at 110-150Mb, & the output (full) cache is 203-300Mb. |
Maybe it is a minor thing but with non existent hackage index timestamps all builds logs:
which is a little bit annoying. I see the advantage of using artifical index state to invalidate cache but maybe we could update to the last index state given by |
PR just wanted to fix the caching situation for everybody. Even the work on updating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let it be +1, we will end to have a real one anyways and the actual one emits the warning, thanks for fixing cache
Thank you. I just was focused on the other thing in this PR & was not prepared to change the scope. |
Superb, workflow finished: https://github.com/haskell/haskell-language-server/runs/4591215047?check_suite_focus=true |
It is made to fix the current situation, for example, if
Caching
workflow inmaster
got canceled for some reason, on a successful run of the action in the workflows - workflows still runs the post-hooks that actions have, which would cache & share thecabal
store
of the canceled workflow.On merge, this change would refresh caches, which should fix
Windows
build waits.