Subsequent tactics test rebased on top of fixed lsp-test #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
subsequent-tactics-test-rebased
branch
from
1b0d700 to
b62da29
Compare
|
I took the liberty of rebasing this @pepeiborra , hopefully it should all pass now. |
michaelpj
approved these changes
Jan 2, 2022
|
I'll leave this to you to merge, I wasn't completely clear from the other PR whether this was done or not. |
|
Not intended for merging, just to show that the new test in #2479 doesn't model the reported bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #2479 on top of #2494 to pick up a bug fix in lsp-test (haskell/lsp#376) that was preventing the new test from working properly