Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class plugin bump up #2475

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Class plugin bump up #2475

merged 5 commits into from
Dec 13, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Dec 12, 2021 •
edited by gitpod-io bot
Loading

Now it supports GHC 9.0

Ref: #297

@Ailrun Ailrun force-pushed the class-plugin-bump-up branch 2 times, most recently from 0e53c5a to d4ab645 Compare December 12, 2021 21:35
@Ailrun Ailrun force-pushed the class-plugin-bump-up branch from d4ab645 to 3906a1a Compare December 12, 2021 23:13
@Ailrun Ailrun mentioned this pull request Dec 12, 2021
Closed
35 tasks
jneira
jneira reviewed Dec 13, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, we are getting closer to ghc-9 full support
I would take a look to hls .cabal file, now plugins have ghc bounds in that file to allow hackage installations for ghc-9

@Ailrun
Copy link
Member Author

Ailrun commented Dec 13, 2021

Oops, you are right, I missed the hls .cabal file. I will fix that soon.

jneira
jneira approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks! to merge when ci is happy

@jneira jneira added the merge me Label to trigger pull request merge label Dec 13, 2021
@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Dec 13, 2021 •
edited
Loading

Looks like 1 test build was not terminating. Restarted the workflow.

(& the next one thrown
Screenshot-2021-12-13-18:07:58
then reported success that all tests passing & simultaneously aborted with error return code ... whatever that meant ..., restarted again).

@mergify mergify bot merged commit ae6f707 into haskell:master Dec 13, 2021
@Anton-Latukha
Copy link
Collaborator

Thank you, @Ailrun, & everybody,

@Ailrun
Copy link
Member Author

Ailrun commented Dec 13, 2021

@Anton-Latukha

simultaneously aborted with error return code

This part is actually because I cancelled it. It's somehow blocked indefinitely. Thank you for the restart.

@Ailrun Ailrun deleted the class-plugin-bump-up branch December 13, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ailrun @Anton-Latukha @jneira