Fix some pragma completion cases #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Dec 12, 2021
|
@jneira Thank you. Sadly, I'm still under tons of work for papers, but this one and class plugin bothers me too much even for the papers :) I will also soon send a class plugin patch for GHC 9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some editors, parenthesis completion can handle a language specific cases. For example, in my Emacs, when I type
{-#it automatically gives
{-##-}However, the current pragma completion plugin does not recognize this case, and completes
{-# LANGUAGE #- #-}which is invalid. This PR cares the editors which fill
#-}or-}for Haskell.