Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: organizing bootstraping #2446

Merged
merged 11 commits into from
Dec 10, 2021

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 7, 2021

Be free at merging #2444, I would rebase this to whatever needed.


Using the same bootstrapping process so workflows have the same setup & so can share the caches between them.

(A work derived from #2427)

@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch 3 times, most recently from 8444e53 to a8ff747 Compare December 7, 2021 11:34
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 7, 2021 12:57
@Anton-Latukha Anton-Latukha marked this pull request as draft December 7, 2021 12:59
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch from a8ff747 to c5d055d Compare December 7, 2021 13:00
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 7, 2021

On caching workflow: added the PR trigger, ran the successful build/test on caching workflow & removed the trigger. The result is in https://github.com/haskell/haskell-language-server/actions/runs/1549204625.

@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 7, 2021 14:34
@Anton-Latukha Anton-Latukha changed the title CI: bootstrap organization CI: bootstraping organization Dec 7, 2021
.github/workflows/bench.yml Outdated Show resolved Hide resolved
.github/workflows/bench.yml Outdated Show resolved Hide resolved
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reorganizing ci scripts, they will look great, only some minor comments

@jneira

This comment has been minimized.

@Anton-Latukha Anton-Latukha marked this pull request as draft December 9, 2021 13:20
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch from 3271391 to 876b048 Compare December 9, 2021 13:26
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 9, 2021 14:59
@Anton-Latukha

This comment has been minimized.

@jneira

This comment has been minimized.

.github/workflows/bench.yml Outdated Show resolved Hide resolved
.github/workflows/bench.yml Outdated Show resolved Hide resolved
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch from 876b048 to 5e4c4fc Compare December 9, 2021 15:40
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 9, 2021

[skip circleci]

Seems I encountered that in several forms.
Where is to find that information?

I found, https://circleci.com/docs/2.0/skip-build/ but that talks about [skip ci] & mentions to not work for the fork PRs.

@jneira
Copy link
Member

jneira commented Dec 9, 2021

[skip circleci]

Seems I encountered that in several forms. Where is to find that information?

I found, https://circleci.com/docs/2.0/skip-build/ but that talks about [skip ci] & mentions to not work for the fork PRs.

yeah and it only works in commit messages, I made up a hack to skip the build
see

@Anton-Latukha Anton-Latukha requested a review from jneira December 9, 2021 17:20
@Anton-Latukha Anton-Latukha marked this pull request as draft December 9, 2021 17:21
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch from 2329411 to 8d2e805 Compare December 9, 2021 17:27
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing comments

@Anton-Latukha Anton-Latukha marked this pull request as draft December 9, 2021 21:17
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 9, 2021 22:47
@Anton-Latukha

This comment has been minimized.

@Anton-Latukha Anton-Latukha changed the title CI: bootstraping organization CI: bootstraping organization [skip circleci] Dec 9, 2021
@Anton-Latukha Anton-Latukha changed the title CI: bootstraping organization [skip circleci] CI: organizing bootstraping Dec 9, 2021
@jneira

This comment has been minimized.

@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch 3 times, most recently from 79eebe7 to 3a62fae Compare December 10, 2021 09:50
@Anton-Latukha Anton-Latukha marked this pull request as draft December 10, 2021 09:51
@Anton-Latukha

This comment has been minimized.

@Anton-Latukha

This comment has been minimized.

It seems would not be needed.
`cabal.project` has pinned Hackage revision & when HLS code updates in `master`
is during merges.
This were organized but others were ommited, because `build` & `hackage` have a
different purpose I postphoned addind bootstrap to them.
Seems like HLS does not plan to use submodules.
Still kept the 9.0.1 bootstrap, because the very next workflow standard GHC
update would hit the need of that code.
Merely to refresh the Circle-CI report status in the PR
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-07-ci-bootstrap-org branch from efa11d0 to e8f2670 Compare December 10, 2021 15:35
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 10, 2021 18:22
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks again, i hope my succesive cmments were not too burdensome

@jneira jneira merged commit cf84ef5 into haskell:master Dec 10, 2021
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 10, 2021

Well, besides we could established minimization a bit earlier. I do not know how to properly establish that. I wanted to copy-paste the bootstrap code, I did not wanted to fit it to the workflows, so it would be the same & essentially sacked or cleaned-up afterward. & I also had an eyeball to preserve the same code to submit the next steps, & so some of them would be used & then look at & the clean-up. But that is probably too much of a stretch to multiple PRs.

I basically wanted to get 1 PR & split its code into 3 stages & merge them & then do clean-up. But as I said that is probably a stretch & submitting PRs which code has unused features & code that may be used in the future, that is: "4. Code with added features".

A kind & strong ask & encouragement to keep PRs to the code so they would be quickly mergable, & so to fit the code to the purpose so maintainer does not need to go over it, would've made me go over the whole codebase more thoroughly & submit all additional code that is not related to current code into next PRs where it would relate. Then & the law of triviality (Wadler's law) & the self-aware understanding of that looms over the process. It is well Ok here, because the main trap of "Wadler's law" is bogging the process documentation in rewording/discussion (since I loved to contribute docs in the past - I "got the experience" & the idea & only recently found the literate famous nicely put law). Several small details some put & some removed & the last note probably still would've happened nevertheless. It all also was heavily multiplied by numerous CI blockages & waiting times in the process, rebases.

What I want to take from this is to on splitting the PR I should treat each small PR as a one PR & code "in itself".

@Anton-Latukha Anton-Latukha deleted the 2021-12-07-ci-bootstrap-org branch December 10, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants