Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest prettyprinter API #2352

Merged
merged 2 commits into from
Nov 14, 2021
Merged

Update to latest prettyprinter API #2352

merged 2 commits into from
Nov 14, 2021

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Nov 14, 2021 •
edited
Loading

Emits a couple of deprecation warnings otherwise. Forces prettyprinter >= 1.7.1

@michaelpj
Copy link
Collaborator

Might need an index-state bump?

@fendor fendor force-pushed the polish/deprecated-prettypinter-hierarchy branch from a9a9e1a to 2b7a582 Compare November 14, 2021 11:44
@fendor
Copy link
Collaborator Author

fendor commented Nov 14, 2021 •
edited
Loading

Ah, no 1.7.1 is not greater or equal to 1.7.1.0. So just version comparison stuff.

@fendor fendor force-pushed the polish/deprecated-prettypinter-hierarchy branch from 2b7a582 to 1e22004 Compare November 14, 2021 11:57
jneira
jneira approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fendor fendor force-pushed the polish/deprecated-prettypinter-hierarchy branch from 06f8f03 to 9628d70 Compare November 14, 2021 15:50
@pepeiborra pepeiborra merged commit 1eb133f into haskell:master Nov 14, 2021
pepeiborra added a commit that referenced this pull request Nov 23, 2021
@pepeiborra
Revert "Update to latest prettyprinter API (#2352)"
5e24ea3 
This reverts commit 1eb133f.

This change breaks compatibility with Stackage LTS 16 (GHC 8.8)
pepeiborra added a commit that referenced this pull request Nov 23, 2021
@pepeiborra
Revert "Update to latest prettyprinter API (#2352)" (#2389)
01126b8 
* Revert "Update to latest prettyprinter API (#2352)"

This reverts commit 1eb133f.

This change breaks compatibility with Stackage LTS 16 (GHC 8.8)

* bump ghcide version number

* bump wingman version number
@fendor fendor mentioned this pull request May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fendor @michaelpj @jneira @pepeiborra