[skip circleci] Rename hlint test data files and add regression tests #2321
Conversation
jneira
changed the title
|
Tests are green after the usual reruns, so I think it could be reviewed although most changes are naming related |
There was a problem hiding this comment.
Correct waitForProgressDone hls-test-utils implementation: it was a exact duplicate of waitForAllProgressDone so it is replaced with the definition from the same function in the ghcide test suite
Can we share this? Perhaps we need to upstream some more test helpers into lsp-test?
| @@ -285,3 +316,9 @@ hlintConfigWithFlags flags = | |||
| where | |||
| unObject (Object obj) = obj | |||
| unObject _ = undefined | |||
|
|
|||
| knownBrokenForHlintOnGhcLib :: String -> TestTree -> TestTree | |||
There was a problem hiding this comment.
It's not immediately obvious to me what these mean or why it's these versions. Haddock?
There was a problem hiding this comment.
Hmm it is a somewhat long history, will try to add a concise comment although the entire thing should be explained in the plugin README or something (TBD)
There was a problem hiding this comment.
Not sure if i explained it clearly 🤔
|
Err why mergify merged the pr without waiting for required checks?, argh |
|
I think the post_job's are not shown until they have started, so if test postjob has not started but benchmark or nix one have ended succesfully, you can merge the pr, will try to fix giving them unique names |
waitForProgressDonehls-test-utils implementation: it was a exact duplicate ofwaitForAllProgressDoneso it is replaced with the definition from the same function in the ghcide test suite