Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new queue rules for mergify bot #2301

Merged
merged 7 commits into from
Oct 28, 2021
Merged

Use new queue rules for mergify bot #2301

merged 7 commits into from
Oct 28, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 25, 2021 •
edited by gitpod-io bot
Loading

@jneira jneira changed the title Use new queue rules Use new queue rules for mergify bot Oct 25, 2021
@jneira jneira added merge me Label to trigger pull request merge and removed merge me Label to trigger pull request merge labels Oct 26, 2021
@jneira jneira requested review from pepeiborra and Ailrun October 26, 2021 10:35
@jneira
Copy link
Member Author

jneira commented Oct 27, 2021

@pepeiborra and others: this have to be done before january, it is ok to be merged?

@jneira jneira requested a review from michaelpj October 27, 2021 21:36
@michaelpj
Copy link
Collaborator

Looking at the doc, they have e.g. CI statuses in the required conditions to get out of the queue. Don't we need that too? Or does it automatically require all green statuses?

@jneira
Copy link
Member Author

jneira commented Oct 28, 2021

Looking at the doc, they have e.g. CI statuses in the required conditions to get out of the queue. Don't we need that too? Or does it automatically require all green statuses?

Last one

Mergify always respects the branch protection settings

https://docs.mergify.com/actions/merge/?highlight=branch%20protection

@michaelpj
Copy link
Collaborator

Maybe worth a comment in the settings file, then.

@jneira
Copy link
Member Author

jneira commented Oct 28, 2021

[skip circleci]

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Oct 28, 2021
@jneira jneira merged commit 939caa3 into haskell:master Oct 28, 2021
pepeiborra pushed a commit that referenced this pull request Nov 2, 2021
@jneira @pepeiborra
Use new queue rules for mergify bot (#2301)
1204cce 
* Use new queue rules

* Add queue action

* Remove method from the queue rule

* Correct yaml

* Comment about empty conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@Ailrun Ailrun Awaiting requested review from Ailrun

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneira @michaelpj