Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace log events and fix ghcide logger #2277

Merged
merged 9 commits into from
Oct 16, 2021
Merged

Trace log events and fix ghcide logger #2277

merged 9 commits into from
Oct 16, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Oct 16, 2021 •
edited by gitpod-io bot
Loading

This PR contains a bunch of commits spin out of #2263, including:

  • Fixed the ghcide logger which was producing always verbose output and ignoring the --verbose flag
  • Send log events to the event log trace
  • Other minor logging and tracing changes

jneira
jneira approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Oct 16, 2021
@mergify mergify bot merged commit 37370f4 into master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @jneira