-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the ghcide test plugin in HLS test suites #2243
Conversation
fe1f476
to
c37c2a2
Compare
c37c2a2
to
0561523
Compare
thanks, i was about to make optional the rename test suite for windows and ghc-9.0.1 |
/rerun-workflow Testing |
eval plugin tests failed for linux int two consecutive runs |
My recent commit broke it - still working on it |
9dc743e
to
44bddfa
Compare
.github/workflows/test.yml
Outdated
@@ -30,6 +30,8 @@ jobs: | |||
test: | |||
needs: pre_job | |||
runs-on: ${{ matrix.os }} | |||
env: | |||
TASTY_NUM_THREADS: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has a different effect from pass -j1
to the test executable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the env var is equivalent to the arg, if docs are correct: https://github.com/UnkindPartition/tasty#runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is equivalent, but I don't think it worked. Did I put it in the right place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we are already passing -j1
to tasty via --test-options
in the workflow, do you suspect the cli arg could have a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you are right, I missed that -j1
is already there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a shot in the dark but i am trying with -j1
directly for cabal
55bbd70
to
29272f8
Compare
9e02d4c
to
7cb37ea
Compare
Instead, send all ghcide output through the logger and keep stderr open for fatals
83ddc25
to
865dc8d
Compare
The problem with the tactics test suite was also Main modules. Fixed it in my last commit, this PR should be getting merged very soon. |
many many thanks, in my last try almost all tactic tests failed with session timeouts |
The ghcide test plugin installs a
CustomMethod
handler that allows to interact with the build queue and do things like waiting for the queue to be empty. It's installed by the ghcide main driver but not by the HLS test driver.This PR refactors things so that it will be installed automatically by the
defaultMain
driver.