added tests for qualified completions #2198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that there is a bug, and I suspect it's related to local modules. Could you break the failing test down into two: one for qualified local module imports and one for qualified package module imports? |
|
It seems the test fail is legitimate |
|
I included these tests in #2332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some tests related to #2082
The first test passes, however the second test fails.
Is this enough to prove that the functionality in issue 2082 is working fine?
However, I believe this also proves we have a more specific bug / feature request related to aliased qualified import completions
this is not intended to be merged as is, as the second test is failing